Skip to content

fix: replace ssh config block in-place #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 9, 2024
Merged

fix: replace ssh config block in-place #211

merged 2 commits into from
Feb 9, 2024

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented Feb 9, 2024 •
edited
Loading

This PR introduces two changes:

  1. Replace vscode block in-place in the SSH config
  2. Adds an additional guard against replacing user-added blocks that look like an old-form SSH config block (without block markings)

TBH, we could probably remove the old block detection entirely instead of this additional check, but didn't want to make that decision here.

@ericpaulsen
Copy link
Member

related issue: #210

@mafredri mafredri marked this pull request as ready for review February 9, 2024 16:18
@mafredri mafredri requested a review from code-asher February 9, 2024 16:18
@mafredri mafredri self-assigned this Feb 9, 2024
@mafredri mafredri merged commit 35f6967 into main Feb 9, 2024
@mafredri mafredri deleted the mafredri/fix-ssh-block-updates branch February 9, 2024 16:48
@code-asher code-asher mentioned this pull request Feb 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

@code-asher code-asher Awaiting requested review from code-asher

Assignees

@mafredri mafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mafredri @ericpaulsen @kylecarbs