Reuse agent metadata watchers #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has two effects: 1. Lower overhead from establishing the watchers over and over. 2. No more flashing in the tree as the watchers get recreated and we wait for the first update.
code-asher
force-pushed
the
asher/reuse-watchers
branch
from
49fbe38 to
c94247a
Compare
|
@Kira-Pilot Just FYI I was going to push this directly to main to get a test release out, but I decided to open a PR first and merge it in that way so it could be reviewed later just in case I missed something! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup PR to reuse watchers to make the automatic refresh less janky.
This has two effects:
I renamed
CoderTreeItemTypeto make clear it was for openable items only, not for the metadata items and not for the new error item.Because I needed to refactor the watchers a little I added a line for when something with the metadata fails, rather than quietly disposing (tested by manually adding
throw new Error("hey")).