Automatically refresh workspaces #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code-asher
force-pushed
the
asher/refresh-workspaces
branch
3 times, most recently
from
e645f38 to
abf2038
Compare
Kira-Pilot
reviewed
Feb 1, 2024
Kira-Pilot
approved these changes
Feb 1, 2024
code-asher
force-pushed
the
asher/refresh-workspaces
branch
from
abf2038 to
298685a
Compare
code-asher
force-pushed
the
asher/refresh-workspaces
branch
from
298685a to
62e5143
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #184.
One existing issue with refreshing that is made more apparent with the auto refresh is that it reestablishes all the agent metadata watchers which both feels wasteful and causes the metadata to flash as it disappears for a moment then comes back when the watcher comes online. In a followup PR I think I will refactor this to reuse existing watchers when possible.
Stacked on #202.