Skip to content

feat: expand ${userHome} in tls settings paths #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

coryb
Copy link
Contributor

@coryb coryb commented Dec 6, 2023

For parity with the jetbrains-coder plugin allow for HOME directory expansion in the path locations for tls configuration settings. Using the ${userHome} variable as this is used in other VSCode configurations like launch.json.

For parity with the jetbrains-coder plugin allow for HOME directory
expansion in the path locations for tls configuration settings.  Using
the `${userHome}` variable as this is used in other VSCode
configurations like launch.json.
@coryb
Copy link
Contributor Author

coryb commented Dec 8, 2023

@code-asher would appreciate a review of this small PR. Thanks!

@code-asher code-asher self-requested a review December 8, 2023 00:21
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@code-asher code-asher merged commit ea02218 into coder:main Dec 8, 2023
@code-asher
Copy link
Member

Released in v0.1.29.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants