fix: ensure coder.coder-remote dir exists #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jsjoeio
commented
Jan 10, 2023
jsjoeio
commented
- chore(deps): add fs-extra
- fix: ensure coder.coder-remote dir exists
This adds a handy function called `ensureDir` which creates a directory if it doesn't yet exist.
This ensures the coder.coder-remote dir exists before writing a file to the `globalStorageUri.fsPath`. Fixes a bug occurring on macOS.
kylecarbs
approved these changes
Jan 10, 2023
| @@ -247,6 +248,7 @@ export class Storage { | |||
| const url = this.getURL() | |||
| axios.defaults.baseURL = url | |||
| if (url) { | |||
| await ensureDir(this.globalStorageUri.fsPath) | |||
There was a problem hiding this comment.
You should add this for the session token too!
There was a problem hiding this comment.
Ah good call. Let me do that now!
|
@kylecarbs can I get write access to merge my own PRs? |
kylecarbs
approved these changes
Jan 10, 2023
|
Yup! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.