chore(internal/provider): refactor cached_image_resource #46
Conversation
| "CODER_AGENT_SUBSYSTEM": "one,two", | ||
| "CODER_AGENT_TOKEN": "string", | ||
| "CODER_AGENT_URL": "string", |
There was a problem hiding this comment.
These can simply be handled via extra_env. We don't need to test for them here.
| "CODER_AGENT_TOKEN", "some-token", | ||
| "CODER_AGENT_URL", "https://coder.example.com", |
There was a problem hiding this comment.
making sure the coder args still make their way into computed env.
| val = strings.Join(sa.GetSlice(), ",") | ||
| } else { | ||
| val = opt.Value.String() | ||
| } |
There was a problem hiding this comment.
What separation does this use by default? I had assumed it would already be comma separated and we can just .String() 🤔
There was a problem hiding this comment.
It uses CSV format by default. Calling the String() method didn't work for me. This may be a bug in coder/serpent but I haven't looked too much closer.
There was a problem hiding this comment.
Is it possible to lookup the inputs that you had when it failed? I'd be happy to file the issue upstream, if there is one.
There was a problem hiding this comment.
I'll try to create a minimal example and file a PR in coder/serpent.
Addresses some non-blocking comments from #44:
cached_image_resource.goto separate internal packagestfutilandimgutil.helpers.go.