feat: add remote_repo_build_mode envbuilder option #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
commented
Aug 7, 2024
johnstcn
commented
Aug 8, 2024
| verbose = true | ||
| workspace_folder = {{ quote .Repo.Dir }} |
There was a problem hiding this comment.
review: this isn't necessary any longer as far as I can tell
johnstcn
commented
Aug 8, 2024
Comment on lines
-137
to
+138
| _ = cli.ContainerRemove(ctx, ctr.ID, container.RemoveOptions{ | ||
| if err := cli.ContainerRemove(context.Background(), ctr.ID, container.RemoveOptions{ | ||
| RemoveVolumes: true, | ||
| Force: true, | ||
| }) | ||
| }); err != nil { | ||
| t.Errorf("removing container: %s", err.Error()) | ||
| } |
There was a problem hiding this comment.
drive-by: this wasn't cleaning up properly due to context.Canceled
dannykopping
approved these changes
Aug 9, 2024
There was a problem hiding this comment.
Unblocking stamp
I don't have much context so best to wait for @mafredri as well?
mafredri
approved these changes
Aug 9, 2024
johnstcn
force-pushed
the
cj/option-remote-repo-mode
branch
from
dd173ee to
8351aac
Compare
johnstcn
added a commit
that referenced
this pull request
Aug 9, 2024
Adds support for setting the --remote-repo-build-mode Envbuilder option. Defaults to true if not set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for setting the
--remote-repo-build-modeEnvbuilder option.