fix: correctly patch template acl #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ethanndickson and the rest of your teammates on |
|
Should we also provide/update the example to demonstrate this (if not done already)? |
|
No, this PR just gives users the expected behavior that when they omit an ACL item from the list in their Terraform config, it will get deleted. |
deansheather
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The provider currently does not remove users or groups from template ACL when applying a config.
This was unfortunately missed by tests, but caught by our use of the provider to manage our dogfood template.
Merely omitting a ACL item in a
coderdAPI request is not enough to delete it, the role string must be set to an empty string.ACL items will now be deleted from the template when they are removed from the config and applied.