feat: add app share property #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylecarbs
reviewed
Oct 6, 2022
kylecarbs
approved these changes
Oct 6, 2022
provider/app.go
Outdated
Comment on lines
93
to
95
| "users. Permitted application sharing levels can be " + | ||
| `controlled via a flag on "coder server". Defaults to ` + | ||
| `"owner" (sharing disabled).`, |
There was a problem hiding this comment.
We should wait to allow the blocking of sharing globally IMO.
There was a problem hiding this comment.
Talked to Kyle on slack and he agrees we should keep the flag but it should default to all levels being available if you're entitled to the feature.
deansheather
changed the title
DanielleMaywood
pushed a commit
that referenced
this pull request
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
shareproperty to workspace app resources of type string. Must be one of"owner","template","authenticated","public".