Skip to content

chore: do not use GitHub prereleases #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2025
Merged

Conversation

matifali
Copy link
Member

@matifali matifali commented Mar 5, 2025

Removes automatic handling of GitHub releases.
For some reason, the registry isn't recognizing new tags, and we suspect this might be the cause.

@matifali matifali requested a review from dannykopping March 5, 2025 08:42
Comment on lines -60 to -61
prerelease: auto
make_latest: '{{ not .Prerelease }}'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default values are prerelease: false and make_latest: true
https://goreleaser.com/customization/release/#github

@matifali matifali merged commit f95a77f into main Mar 5, 2025
5 checks passed
@matifali matifali deleted the atif/remove-prerelease branch March 5, 2025 08:49
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2025
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭

@matifali
Copy link
Member Author

matifali commented Mar 5, 2025

We discovered that the Terraform registry does not pick up them, although we could not find any documentation.

@johnstcn
Copy link
Member

johnstcn commented Mar 5, 2025

We discovered that the Terraform registry does not pick up them, although we could not find any documentation.

Hence my sadness :(

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants