-
Notifications
You must be signed in to change notification settings - Fork 22
chore: test auto prerelease #347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This configures goreleaser to automate prereleases when we push a tag that contains `pre` or `rc`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤞
.goreleaser.yml
Outdated
prerelease: auto | ||
make_latest: "{{ not .Prerelease }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per https://goreleaser.com/customization/templates/
make_latest: "{{ not .Prerelease }}"
is wrong and
"{{ .Prerelease }}"
will evaluate to pre
It is not a boolean, so my change will not work.
QQ: Can I match a template check for
"{{ .Prerelease == 'pre' }}"
I am assuming templating works the same as they do in Helm charts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like templates aren't supported in make_latest
yet.
There's a PR to support this: goreleaser/goreleaser#5418 that got released in v2.6.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's merged and available as per v2.6.0
goreleaser/goreleaser#5420
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{{ eq (.Prerelease | len) 0 }}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make_latest: {{ not .Prerelease }}
should also return make_latest: true
when .Prerelease
is empty.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverting the change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{{ not .Prerelease }}
should also work as you suggested: https://go.dev/play/p/aDU6YypI2KT
This configures goreleaser to automate prereleases when we push a tag that contains
pre
orrc
Ref: https://goreleaser.com/customization/release/#github