Skip to content

fix: app display name validation #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 13, 2025
Merged

fix: app display name validation #344

merged 2 commits into from
Feb 13, 2025

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Feb 13, 2025

Fixes: #307

This PR enables basic validation for app display name: coder_app has database a constraint on the column length.

@mtojek mtojek self-assigned this Feb 13, 2025
@mtojek mtojek marked this pull request as ready for review February 13, 2025 11:24
@mtojek mtojek requested review from defelmnq and johnstcn February 13, 2025 11:25
johnstcn
johnstcn approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this @mtojek !

@mtojek mtojek merged commit 4b3fc65 into main Feb 13, 2025
5 checks passed
@mtojek mtojek deleted the 307-display-app branch February 13, 2025 11:32
@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnstcn johnstcn johnstcn approved these changes

@defelmnq defelmnq Awaiting requested review from defelmnq

Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: coder_app declaration can attempt to overflow length of column workspace_apps.display_name
2 participants
@mtojek @johnstcn