fix: remove window option from open_in parameter #327
Conversation
There was a problem hiding this comment.
LGTM. Thanks
@johnstcn I am a bit unsure about versioning for this change.
Technically, it is a breaking change. However, given that the added functionality in 2.1.0 was never released in Coder mainline or stable, it is safe to assume that no one should have been using it. And we can patch it as 2.1.1.
Thoughts?
| @@ -17,18 +17,11 @@ resource "coder_agent" "dev" { | |||
| dir = "/workspace" | |||
| } | |||
|
|
|||
| resource "coder_app" "window" { | |||
| resource "coder_app" "tab" { | |||
There was a problem hiding this comment.
The resource name is tab, so we the property coder_app.tab.open_in is available, but you're referring to coder_app.slim-window.open_in hence the issue?
There was a problem hiding this comment.
Yes indeed , nice catch - just fixed it. 🤔
Another option would be that we just make WDYT @defelmnq ? |
The open_in parameter currently being released was first ment to contain
windowas one of the options - after more review it is not relevant anymore and has to be removed.