fix: update to terraform-plugin-sdk v2.34.0 #290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @spikecurtis and the rest of your teammates on |
johnstcn
approved these changes
Sep 24, 2024
Merge activity
|
|
@spikecurtis we can patch the 1.0 after cherry picking this change into |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speculative fix in relation to coder/coder#14726
There have been several issues fixed in the plugin-sdk and its dependencies about go routines and the RPC protocol. Since our
coderplugin is itself very, very simple in design (it generally just reads data from environment variables for data sources, and just does validation on resources), it's hard to imagine a hang in our provider schema code (not impossible tho). The error reports we've seen all show the Coder provider as the one that is involved intext file busy, so it seems likely that it's something unique about thecoder/coderprovider.hashicorp/kubernetesis used by both customers who reported thetext file busyerror, and it is on SDK version 2.29+ and we were back on 2.20 before this PR.