feat: annotate resources withSchemaVersion
#244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtojek
changed the title
SchemaVersionSchemaVersion
johnstcn
approved these changes
Jun 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #224
Changes:
SchemaVersionto 1 (first revision). One this is done, we can use StateUpgraders to transform the resource stateRe FIXMEs (actually more important than this PR):
Coder provisioner uses
terraform-plugin-coderin different contexts - a dry run, a template run, a workspace build, etc. We can't usehelpers.RequireEnv()in other modes than "workspace build", as the provisioner does not set these values (empty variable). If we switch tohelpers.RequireEnv()now, "template import" will fail due to unset env values.We can implement a workaround by passing the extra env variable
CODER_WORKSPACE_BUILD_ID=.... If this variable is set, the plugin should presence the required env values.