-
Notifications
You must be signed in to change notification settings - Fork 22
chore: add integration test for provider #233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking super slick, added a few notes
} | ||
} | ||
|
||
// TODO: test coder_external_auth and coder_git_auth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
coder_git_auth
could be skipped as it has been deprecated for a while.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice testing improvement, so let's get it in.
@@ -0,0 +1,65 @@ | |||
terraform { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: curious if we can use a file from the examples directory, or put it there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could use some, but most have dependencies like gcloud credentials that we can't necessarily provide.
Will add to GitHub testing workflow in a separate PR. |
This PR adds integration tests for the provider against an arbitrary version of Coder.
Example usage:
Testing methodology: