docs: Adds coder_git_auth deprication notice (#203) #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
cdrcommunity
added a commit
to coder/cla
that referenced
this pull request
Apr 26, 2024
matifali
reviewed
Apr 27, 2024
| @@ -3,16 +3,15 @@ | |||
| page_title: "coder_external_auth Data Source - terraform-provider-coder" | |||
| subcategory: "" | |||
| description: |- | |||
| Use this data source to require users to authenticate with an external service prior to workspace creation. This can be used to pre-authenticate external services in a workspace. (e.g. gcloud, gh, docker, etc) | |||
There was a problem hiding this comment.
gcloud, gh and docker are the binary names. IMO, gh makes better sense.
matifali
requested changes
Apr 27, 2024
|
Can be closed if we do #250. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds deprication notice to git_auth in docs and renames 'gh' to 'GitHub' in external_auth docs for clarity.