Skip to content

docs: Adds coder_git_auth deprication notice (#203) #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kyle-pazdel
Copy link

Adds deprication notice to git_auth in docs and renames 'gh' to 'GitHub' in external_auth docs for clarity.

Copy link

github-actions bot commented Apr 26, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@kyle-pazdel
Copy link
Author

kyle-pazdel commented Apr 26, 2024

I have read the CLA Document and I hereby sign the CLA

@kyle-pazdel
Copy link
Author

recheck

@@ -3,16 +3,15 @@
page_title: "coder_external_auth Data Source - terraform-provider-coder"
subcategory: ""
description: |-
Use this data source to require users to authenticate with an external service prior to workspace creation. This can be used to pre-authenticate external services in a workspace. (e.g. gcloud, gh, docker, etc)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gcloud, gh and docker are the binary names. IMO, gh makes better sense.

Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs are generated files so we should update the description in the go code,
for example,

Description: "Use this data source to require users to authenticate with a Git provider prior to workspace creation. This can be used to perform an authenticated `git clone` in startup scripts.",

@matifali
Copy link
Member

matifali commented Jul 2, 2024

Can be closed if we do #250.

@matifali matifali closed this Jul 2, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants