fix: improve coder_script related docs #191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
reviewed
Feb 9, 2024
provider/script.go
Outdated
Comment on lines
29
to
31
| if !runOnStart && startBlocksLogin { | ||
| return diag.Errorf("start_blocks_login can only be set if run_on_start is true") | ||
| } |
There was a problem hiding this comment.
Does this extra check risk breaking any existing usage?
There was a problem hiding this comment.
Possibly, but it also alerts users to a misconfiguration that will cause unexpected results.
There was a problem hiding this comment.
Might be worth calling this out as a potentially breaking change then. LGTM otherwise 👍
There was a problem hiding this comment.
I broke it out to a separate PR, this was a good callout tbh: #192
johnstcn
approved these changes
Feb 9, 2024
mafredri
force-pushed
the
mafredri/fix-docs-and-validation
branch
from
1f7d0a3 to
62c590d
Compare
johnstcn
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: add extra validation for start_blocks_login(fix!: add extra validation for start_blocks_login #192)