feat: add coder_env
#174
feat: add coder_env
#174
Conversation
Fixes #170
| return &schema.Resource{ | ||
| Description: "Use this resource to set an environment variable in a workspace.", | ||
| CreateContext: func(_ context.Context, rd *schema.ResourceData, _ interface{}) diag.Diagnostics { | ||
| rd.SetId(uuid.NewString()) |
There was a problem hiding this comment.
I considered disallowing envs here, like PATH, CODER_AGENT_TOKEN, etc. However, I opted for doing this agent side instead (we'll log an error).
| @@ -80,6 +80,7 @@ func New() *schema.Provider { | |||
| "coder_app": appResource(), | |||
| "coder_metadata": metadataResource(), | |||
| "coder_script": scriptResource(), | |||
| "coder_env": envResource(), | |||
There was a problem hiding this comment.
Thinking loud: Do we need an "opposite" resource? coder_no_env to remove the ENV variable?
There was a problem hiding this comment.
For sure, I'd say that goes as a prop: resource "coder_env" "" { name = "FOO", unset = true }. Discussion ongoing in coder/coder#10166.
| ForceNew: true, | ||
| Required: true, | ||
| }, | ||
| "value": { |
There was a problem hiding this comment.
Thinking loud: default_value if not set?
There was a problem hiding this comment.
What's the use-case? Maybe we can add it later if we identify one? Since this is an optional string the default value is empty string, which is just fine.
There was a problem hiding this comment.
Something similar to: using generic dot files if the user didn't provide a custom URL. But I agree to postpone it for later until we meet scenario.
There was a problem hiding this comment.
Maybe that can be handled in terraform? Like value = something_something ? other : "fallback", I think this is OK since we're not really looking for user input for variables and it's unlikely you define a coder_env unless you have an idea of what it should be. 🤔
There was a problem hiding this comment.
This is fine for now, thanks for challenging
I opted for the single-var approach (vs multi as described in #170) because I don't see a use-case for setting a lot of environment variables, and I feel it better matches the resource name and I foresee use-cases for per-environment settings (overwrite, unset, prepend, append, etc.).
Fixes #170
Refs coder/coder#10166