feat: add coder_external_auth and deprecate coder_git_auth
#163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpmct
approved these changes
Oct 3, 2023
provider/externalauth.go
Outdated
| // externalAuthDataSource returns a schema for an external authentication data source. | ||
| func externalAuthDataSource() *schema.Resource { | ||
| return &schema.Resource{ | ||
| Description: "Use this data source to require users to authenticate with an external provider prior to workspace creation. This can be used to pre-authenticate external services in a workspace.", |
There was a problem hiding this comment.
Suggested change
| Description: "Use this data source to require users to authenticate with an external provider prior to workspace creation. This can be used to pre-authenticate external services in a workspace.", | |
| Description: "Use this data source to require users to authenticate with an external service prior to workspace creation. This can be used to pre-authenticate external services in a workspace.", |
There was a problem hiding this comment.
don't want to mix up things with terraform providers
There was a problem hiding this comment.
Can we add an example with the gcloud CLI? I think the terms "provider" "service" and "application" would all be confusing as to what it actually does but one single example could go a long way.
|
How is coder_git_auth deprecated? I don't see a message or anything? |
|
There's a deprecation message added to it. It should be displayed when used. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.