feat: support list(string) as coder_parameter #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
approved these changes
Mar 14, 2023
mtojek
commented
Mar 14, 2023
| data "coder_parameter" "users" { | ||
| name = "System users" | ||
| type = "list(string)" | ||
| default = jsonencode(["root", "user1", "user2"]) |
There was a problem hiding this comment.
This is really unfortunate, but we need to pick a single type of property. We need to fallback to string.
There was a problem hiding this comment.
I think it is ok just wondering if list:string could be better to parse if we parse it at all. Just a thought, the current one looks good too.
There was a problem hiding this comment.
It would be definitely easier to parse, but it is aligned with Terraform now, so I'd rather keep like this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: coder/coder#6582
This PR adds another supported type to
coder_parameter, a list of strings.