Skip to content

improve documentation about setting external URLs for coder_app #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
clearfeed bot opened this issue Jan 30, 2024 · 0 comments · Fixed by #196
Closed

improve documentation about setting external URLs for coder_app #186

clearfeed bot opened this issue Jan 30, 2024 · 0 comments · Fixed by #196
Labels
docs Improvements or additions to documentation

Comments

@clearfeed
Copy link

clearfeed bot commented Jan 30, 2024 •
edited by matifali
Loading

it seems documentation at terraform for coder creates confusion:
This should be of the form "<http://localhost>:PORT[/SUBPATH]".
https://registry.terraform.io/providers/coder/coder/latest/docs/resources/app
@matifali matifali added the docs Improvements or additions to documentation label Jan 31, 2024
matifali added a commit that referenced this issue Feb 16, 2024
@matifali
chore: update description for coder_app url
06d0457 
This clarifies where users may be confused about how to set an external URL, as the current description only talks about internal URL usage. 

Closes #186
@matifali matifali mentioned this issue Feb 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: update description for coder_app url coder/terraform-provider-coder
1 participant
@matifali