This repository was archived by the owner on Jan 17, 2021. It is now read-only.
Add a simple bash test #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhooyr
suggested changes
Apr 24, 2019
main.go
Outdated
| @@ -64,6 +64,8 @@ func main() { | |||
| sshFlags = flag.String("ssh-flags", "", "custom SSH flags") | |||
| syncBack = flag.Bool("b", false, "sync extensions back on termination") | |||
| printVersion = flag.Bool("version", false, "print version information and exit") | |||
| port = flag.String("port", "", "Start VS Code on the provided port. If one is not provided a random one is selected") | |||
| noOpen = flag.Bool("no-open", false, "Start VS Code but don't open a Chrome app window") | |||
There was a problem hiding this comment.
lets use $DISPLAY = "" for this
There was a problem hiding this comment.
Yes, similar to how there is an X11 socket whose path is given by $DISPLAY, $DISPLAY on macOS contains the quartz socket.
There was a problem hiding this comment.
WSL is almost certainly using some sort of X11 forwarding so it would have $DISPLAY.
ammario
reviewed
Apr 25, 2019
main.go
Outdated
| @@ -64,6 +64,8 @@ func main() { | |||
| sshFlags = flag.String("ssh-flags", "", "custom SSH flags") | |||
| syncBack = flag.Bool("b", false, "sync extensions back on termination") | |||
| printVersion = flag.Bool("version", false, "print version information and exit") | |||
| port = flag.String("port", "", "Start VS Code on the provided port. If one is not provided a random one is selected") | |||
| noOpen = flag.Bool("no-open", false, "Start VS Code but don't open a Chrome app window") | |||
scsmithr
reviewed
Apr 26, 2019
sreya
force-pushed
the
test
branch
3 times, most recently
from
72f6d59 to
439b37f
Compare
Closed
sreya
added a commit
that referenced
this pull request
Apr 30, 2019
Add a sanity test - Refactor and break out code from main() - Use a random remote port
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.