This repository was archived by the owner on Jan 17, 2021. It is now read-only.
Add option insiders with env-settings #40
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Could you explain why the added complexity to the code and API is justified, over just the solution in #39 . |
|
using environment isn't user friendly in my opinion |
|
Another problem is we don't want users doing |
ammario
force-pushed
the
env-settings
branch
2 times, most recently
from
e889cd7 to
7f1fcdb
Compare
|
I can agree with that, i do believe that you could use 1 variable instead of 2 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the option to use VSCode Insiders default configuration without setting the environment variables