Skip to content
This repository was archived by the owner on Jan 17, 2021. It is now read-only.

Add data-dir and extensions-dir flag #34

Closed
foresthoffman opened this issue Apr 22, 2019 · 5 comments
Closed

Add data-dir and extensions-dir flag #34

foresthoffman opened this issue Apr 22, 2019 · 5 comments
Labels
feature New feature or improvement to functionality

Comments

@foresthoffman
Copy link

It would make sense to also have --extensions-dir and --user-data-dir flags, since both of those are available on code-server.

https://github.com/codercom/code-server/blob/5f40ebb8457380aa1e9955302d9e41a6b042ef14/packages/server/src/cli.ts#L23-L24

@foresthoffman foresthoffman added the feature New feature or improvement to functionality label Apr 22, 2019
@ammario
Copy link
Member

ammario commented Apr 22, 2019

Related #29

I think it's best to have these as environment variables.

@SscSPs
Copy link
Contributor

SscSPs commented Apr 22, 2019

I think env variables are good, but config file would be better, won't have to pass them everytime..
We can have both, env variables having more priority than config. And config having more priority than defaults

@foresthoffman
Copy link
Author

Environment variables can be easily placed in a user's .bashrc or .bash_profile.

@SscSPs
Copy link
Contributor

SscSPs commented Apr 22, 2019

My reason for having a different config file is that other apps should not accidently use those variables. I know this is rare, but possible.
Noone will be going in some other application's configs accidently

@ammario
Copy link
Member

ammario commented Apr 22, 2019

It's not worth worrying about the chance of another application using an environment variable as specific as VSCODE_SETTINGS_DIR

ammario added a commit that referenced this issue Apr 22, 2019
Notably adds support for VS Codium and VS Code insiders.

Resolves #34, #29
ammario added a commit that referenced this issue Apr 22, 2019
Notably adds support for VS Codium and VS Code insiders.

Resolves #34, #29
ammario added a commit that referenced this issue Apr 22, 2019
Notably adds support for VS Codium and VS Code Insiders.

Resolves #34, #29
@ammario ammario unpinned this issue Apr 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature or improvement to functionality
Projects
None yet
Development

No branches or pull requests

3 participants