This repository was archived by the owner on Jan 17, 2021. It is now read-only.
Add ability to upload local binary #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deansheather
force-pushed
the
upload-custom-binary
branch
2 times, most recently
from
096dbb2 to
a6c3b5d
Compare
|
Just tested this with code-server v2 preview 9, and it just works. |
This was referenced Aug 24, 2019
|
How about |
sreya
reviewed
Aug 26, 2019
deansheather
force-pushed
the
upload-custom-binary
branch
from
9f2f843 to
c8e4017
Compare
|
The flag is now |
sreya
approved these changes
Sep 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
--code-server-pathflag that accepts a path to a file on the local machine. It will be uploaded to the code-server path on the remote server instead of the download script being executed.There is no verification of the local binary, so a user could upload something that isn't a code-server binary or a custom binary or something else along those lines.
This allows remote servers with no internet access to have a code-server binary uploaded to them, which is useful for extremely secure environments.
Closes #73.