GitBash and MinGW support #132

Merith-TK · 2019-08-15T03:33:52Z

TL;DR

cmd.exe is not supported, please use git4win or msys2
Rewrote PR from MSYS/MINGW Client Support (FINNALLY Working) #127
Fixed a ghost path creation error in ensureDir()

Summary of Edits

Fixed file pathing for windows client
Fixed ghost path creation on windows client
Added check to fix variables when using windows clients

Progress

First Build: sshcode functions. barely
https://user-images.githubusercontent.com/10422110/61765201-ef1c0e80-ad90-11e9-87cb-b46e6dc2a909.gif
Second Build: Opens Chrome "app" window
https://user-images.githubusercontent.com/10422110/62153007-8533c580-b2b8-11e9-9d2b-03e25af9bbd0.gif
Third Build: Fixed the sshmaster session bug that gave a useless error (thanks @deansheather )
https://user-images.githubusercontent.com/10422110/62803352-094b3180-ba9f-11e9-818f-4c4b93fb60ed.gif
Fourth Build: Rsync works properly, assuming you have it in path
https://user-images.githubusercontent.com/10422110/63072181-48cab100-bed7-11e9-9d4b-97d7799e95fe.gif
Fifth Build: Path detection/correction works
https://user-images.githubusercontent.com/10422110/65101607-70e97c00-d97d-11e9-8eed-56205ad3e5b3.gif
Sixth Build: fixed ghost path creation via ensureDir()
Seventh Build: Able to open remote paths
- ~~Rev 1: finally got it through travis.~~ breaks windows support,
Eighth Build: passes freaking travis, adds check to see if the host is windows, if so, apply the correct variables, if not, use the default variables
Ninth Build: Everything EXCEPT chrome works.
Tenth Build: Chrome works

Latest Build:

Resolving paths is now fully functional.
Ghost paths are no longer created on the client, (bug with patches to ensureDir()
The following formats now work for opening remote paths, /Workspace, Workspace, ~/Workspace, Workspace/
Code cleanup

main.go

.gitignore

main.go

sshcode.go

deansheather · 2019-09-17T12:53:58Z

Is this still being worked on? The hardcoded C:\mingw64 thing is still an issue. Would like to merge this soon.

Meanwhile, sshcode seems to work on WSL now other than a few small hiccups.

Merith-TK · 2019-09-17T20:00:07Z

It is being worked on, i am slowly working on a home detector, see https://github.com/Merith-TK/Personal-Projects/blob/master/Home.go

Also school started a few weeks ago and i have been basically swamped. and i cant even test it at school during lunch because they blocked ssh... for some stupid reason

MOST RECENT PUSH FIXED THE ISSUE

…nto msys-support

main.go

sshcode.go

main.go

settings.go

sshcode.go

main.go

sshcode.go

deansheather · 2020-03-13T18:36:08Z

In that case we should just add a section to the README which says what env variable to use depending on git bash or msys.

Merith-TK · 2020-04-08T03:30:14Z

I still don't want to rewrite the entire path fixing function but I am working on it since the F***ing coronavirus has canceled my plans.
https://cdn.merith.tk/workspace/merith/go-sshcode/sshcode.go
2020-04-07 20:22:10 INFO Resolved windows path 'C:/msys64/Workspace' to '/msys64/Workspace
is where I am at at the moment,
What would be helpful is a command like winpath in wsl. because that thing you feed it a unix path, it will give the windows equivilant

EDIT, i am running sshcode.exe [email protected] --skipsync /Workspace

EDIT2: I am ready to throw my computer out the window
{ cd / && pwd -W; } | sed 's|/|\\|g' returns C:\Program Files\Git on gitbash
and C:\msys64\ on msys

Merith-TK · 2020-04-08T06:05:40Z

one second, need to undo a personal modification

Merith-TK · 2020-04-08T18:10:25Z

Don't know whats going on with the current Travis build for you guys, but the build for me is working...
https://travis-ci.org/github/Merith-TK/sshcode

sshcode.go

kylejbrk · 2020-04-10T13:06:52Z

Any updates on this? Looking forward if this can run via Gitbash/Windows.

Merith-TK · 2020-04-10T18:05:22Z

@kylejbrk

Any updates on this? Looking forward if this can run via Gitbash/Windows.

My fork is completely functional for gitbash, msys2, and mingw.
waiting on it to be merged

You can clone my repo in its current state and build it yourself if you like

Merith-TK · 2020-04-18T03:07:06Z

Dont know what broke travis for you guys, but it passes on my end
https://travis-ci.org/github/Merith-TK/sshcode

deansheather

Some of my earlier reviews haven't been fixed properly.

deansheather · 2020-04-18T07:57:21Z

Please re-request a review when you want this to be reviewed and merged. I don't read most of my github emails because I get too many, but I get a notification on slack if I'm requested for review.

sshcode.go

main.go

deansheather · 2020-04-20T23:55:09Z

I can't merge this automatically because of glitch with travis. The build passed on travis but didn't get reported to github. I'll squash and merge this manually tomorrow.

Merith-TK · 2020-04-21T00:08:08Z

Alright, hope people find this useful!

Supports git bash and mingw on Windows. Does not support cmd.exe. Signed-off-by: Dean Sheather <[email protected]> Co-authored-by: Merith <[email protected]>

deansheather · 2020-04-27T16:59:46Z

Squashed and merged via 50e859c

Merith-TK added 3 commits August 14, 2019 20:02

clean push

8ef3fdd

patched

1e63329

fixed stupid error

8346a94

deansheather suggested changes Aug 15, 2019

View reviewed changes

main.go Outdated Show resolved Hide resolved

main.go Outdated Show resolved Hide resolved

.gitignore Outdated Show resolved Hide resolved

main.go Outdated Show resolved Hide resolved

sshcode.go Outdated Show resolved Hide resolved

Merith-TK added 3 commits August 16, 2019 14:35

requested changes 8-14-2019

1066cd9

Merge branch 'master' into msys-support

075ec62

Merge branch 'master' into msys-support

e0b9466

Merith-TK added 7 commits September 17, 2019 13:00

Merge branch 'master' into msys-support

431fa0a

rewrite path conversion for msys (UNTESTED)

6356414

rewrite path conversion for msys (WORKING)

c0a2e2e

Merge branch 'master' into msys-support

2466c65

fix ghost path creation

b0b134a

Merge branch 'msys-support' of https://github.com/Merith-TK/sshcode i…

059db65

…nto msys-support

Fix opening remote path (UNTESTED)

3675d80

Merith-TK mentioned this pull request Oct 9, 2019

PSST (i made a pr for the original freman/sshcode#1

Open

Merge branch 'master' into msys-support

06c95c2

Merith-TK mentioned this pull request Nov 2, 2019

Windows support on the client-side? #130

Open

Merith-TK added 3 commits November 2, 2019 21:24

Fix windows sending literal string / pass travis

2a12990

Merged Eargollo PR Manually

fb39251

prevent lint.sh and ensuremod.sh from failing in travis

8bff186

Merith-TK requested a review from deansheather November 11, 2019 23:53

Fixed Chrome, renamed 'msysPath' to 'winPath'

b895d1b

deansheather suggested changes Nov 19, 2019

View reviewed changes

deansheather reviewed Nov 21, 2019

View reviewed changes

main.go Outdated Show resolved Hide resolved

fix msys-support completely, fully functional

73309c7

Merith-TK requested a review from deansheather November 30, 2019 17:00

Merge branch 'master' into msys-support

0ce0913

deansheather approved these changes Dec 16, 2019

View reviewed changes

sshcode.go Show resolved Hide resolved

Simplify/rewrite directory detection.

67cb96d

Merith-TK added 2 commits April 7, 2020 23:09

Revert ms-edge modifications

e9c47f2

fix broken revert

836d024

deansheather reviewed Apr 8, 2020

View reviewed changes

Merith-TK added 2 commits April 8, 2020 16:10

add pr suggestions

c2b11f4

add pr suggestions

ad0b772

deansheather reviewed Apr 18, 2020

View reviewed changes

Merith-TK requested a review from deansheather April 18, 2020 18:42

deansheather reviewed Apr 18, 2020

View reviewed changes

sshcode.go Outdated Show resolved Hide resolved

sshcode.go Show resolved Hide resolved

main.go Show resolved Hide resolved

Merith-TK added 2 commits April 18, 2020 12:28

fix typo

8084597

fix typo

5fa66f3

Merith-TK requested a review from deansheather April 20, 2020 20:03

deansheather added 2 commits April 21, 2020 09:50

Remove unnecessary log

8e9ee5f

Remove unnecessary HasPrefix check

d3536be

deansheather approved these changes Apr 20, 2020

View reviewed changes

deansheather added a commit that referenced this pull request Apr 27, 2020

Add git bash and mingw support (#132)

50e859c

Supports git bash and mingw on Windows. Does not support cmd.exe. Signed-off-by: Dean Sheather <[email protected]> Co-authored-by: Merith <[email protected]>

deansheather closed this Apr 27, 2020

Merith-TK deleted the msys-support branch May 2, 2020 22:51

Merith-TK restored the msys-support branch May 2, 2020 22:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GitBash and MinGW support #132

GitBash and MinGW support #132

Merith-TK commented Aug 15, 2019 •

edited

Loading

deansheather commented Sep 17, 2019

Merith-TK commented Sep 17, 2019 •

edited

Loading

deansheather commented Mar 13, 2020

Merith-TK commented Apr 8, 2020 •

edited

Loading

Merith-TK commented Apr 8, 2020

Merith-TK commented Apr 8, 2020

kylejbrk commented Apr 10, 2020

Merith-TK commented Apr 10, 2020

Merith-TK commented Apr 18, 2020

deansheather left a comment

deansheather commented Apr 18, 2020

deansheather commented Apr 20, 2020

Merith-TK commented Apr 21, 2020

deansheather commented Apr 27, 2020

GitBash and MinGW support #132

GitBash and MinGW support #132

Conversation

Merith-TK commented Aug 15, 2019 • edited Loading

TL;DR

Summary of Edits

Progress

Latest Build:

deansheather commented Sep 17, 2019

Merith-TK commented Sep 17, 2019 • edited Loading

deansheather commented Mar 13, 2020

Merith-TK commented Apr 8, 2020 • edited Loading

Merith-TK commented Apr 8, 2020

Merith-TK commented Apr 8, 2020

kylejbrk commented Apr 10, 2020

Merith-TK commented Apr 10, 2020

Merith-TK commented Apr 18, 2020

deansheather left a comment

Choose a reason for hiding this comment

deansheather commented Apr 18, 2020

deansheather commented Apr 20, 2020

Merith-TK commented Apr 21, 2020

deansheather commented Apr 27, 2020

Merith-TK commented Aug 15, 2019 •

edited

Loading

Merith-TK commented Sep 17, 2019 •

edited

Loading

Merith-TK commented Apr 8, 2020 •

edited

Loading