Mingw support?

[1480c1]

Will there any potential future support for mingw-w64 go/windows native (not wsl)?
I'm not exactly sure how sshcode and go work so I'm sorry if this is a dumb question

[sreya]

Right now we only support remote linux environments, I imagine we'd probably support starting sshcode remotely in a docker container before we support native windows since that's more platform-agnostic

[1480c1]

If it's docker then that's fine

[eargollo]

The PR #118 has code that supports Windows with MINGW.

I will be re-submitting this code as soon as #121 gets merged.

[Merith-TK]

I have made a PR with some rather basic mingw/msys support.
only as the user though, not the server
#127

What this does is allow sshcode to run inside a msys client, for example
$ sshcode.exe --skipsync [email protected] will open a sshcode session as if you were running on linux

[eargollo]

The code in #124 should work. I haven't had the time to address the comments in order to get it merged yet.

[Merith-TK]

@eargollo Wanna combine your changes to mine? https://github.com/Merith-TK/sshcode {branch msys-support}

Your changes are for the windows filepath conversion, mine are for getting chrome support. (from what i see atleast)

[eargollo]

Sure thing. Let's do it. Do you want me to merge your changes there? How do you want to do it?

[Merith-TK]

Well, saying our changes make it so the lines wont like up just right, i think we would have to find the diff between our branches and manually add them.

[Merith-TK]

I have added you as a Collaborator to my repo

[Merith-TK]

@eargollo I have applied my code into yours (offline at the moment) and it does execute properly

What i dont fully understand is why your sshcode.go has only (with my code added in) 432 lines of code, and mine has 573?

[eargollo]

I don't recall taking code out but rather adding some lines for the conversion of slashes. I haven't had the time to merge my code into your branch and test it myself.

[Merith-TK]

mayeb yours is slightly out of date? and when i run the merged code, it still works, it turns out i dont know how to use the filepath to open `/home/$USERNAME/workspace` —Merith

…

On Wed, Jul 31, 2019 at 9:05 AM Eduardo Argollo ***@***.***> wrote: I don't recall taking code out but rather adding some lines for the conversion of slashes. I haven't had the time to merge my code into your branch and test it myself. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#94>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACPQOXWBQEVCJZRKT2O2UZLQCGZ53ANCNFSM4HLEWMUQ> .

[deansheather]

Please discuss PR specific stuff in one of the relevant PRs.

[Merith-TK]

quesiton is, which PR do we discuss on?
Mine #127 or his #124 ?