-
Notifications
You must be signed in to change notification settings - Fork 4
Add auto-completion #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 13 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
c103f5e
Add some very basic scaffolding for auto completion
ammario b7749c3
Move completion code into root package
ammario ebea569
Play around
ammario d910fec
mvp + tests
ethanndickson 707afa6
fixup + mid-line bash complete
ethanndickson 91ccb9a
zsh support + file list completion handler
ethanndickson 6db6e6c
fixup
ethanndickson 3a591bf
equals flags
ethanndickson 7b640ff
powershell
ethanndickson 5ae2c90
refactor
ethanndickson cff5dbb
shorthand flags + cleanup
ethanndickson aa6a8d3
review feedback p1
ethanndickson 15ad85c
review p2
ethanndickson 3fcf037
review
ethanndickson c365495
fixup
ethanndickson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can
CurWord
be an index intoAllArgs
? This provides future compatibility with mid-line completions.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To get auto-complete for equals flags (
--flag=
) I'm currently just setting this to empty string before we call any handlers. If we don't do this then anyone writing a flag completion handler would sometimes see--flag=<arg>
as the current word, and other times just<arg>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, what use-case for mid-line completions isn't handled by just truncating the line at the cursor? Everything I tried just works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, ok. If we're truncating the line at the cursor then CurWord's only purpose is to distinguish the true flag value? That makes sense, I think it warrants a comment.