This repository was archived by the owner on Apr 28, 2020. It is now read-only.
FIXES #201 Sail browser extension docker not found error on MacOS #264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @deansheather |
deansheather
approved these changes
Mar 17, 2020
Co-Authored-By: Dean Sheather <[email protected]>
Co-Authored-By: Dean Sheather <[email protected]>
|
@deansheather accepted PR suggestions |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIXES #201 chrome extension: failed to run
docker infoOn MacOS when Chrome is launched from Finder (as opposed to from terminal/shell session) the
$PATHenvironment variable does not contain/usr/local/binwhich is the common location for docker to be installed.This PR adds in
/usr/local/binto be included in the PATH env variable on MacOSdarwin.See similar issues with other browser extensions that rely on Go to execute commands on the user's path:
browserpass/browserpass-legacy#13
browserpass/browserpass-legacy#159