feat: add path-based sharing for kasm #115
Conversation
Co-authored-by: Atif Ali <[email protected]>
| agent_id = coder_agent.example.id | ||
| desktop_environment = "xfce" | ||
| subdomain = true |
There was a problem hiding this comment.
| subdomain = true |
We can drop as it's the default value.
Add a new example below with subdomain = false to share how they can use it without a subdomain.
There was a problem hiding this comment.
It looked like we were using that to show all of the values. I can do a follow-up PR if that is "minimum config to start" and make a section for "Using the module with path-based sharing"
There was a problem hiding this comment.
Don't understand, but probably it's needed for the path-based service to work.
There was a problem hiding this comment.
Exactly, this leverages javascript as a fast path rewrite to provide the configuration in a way that the vnc.html page can parse as a valid configuration, thus setting the websocket address to the proper path.
| echo "ERROR: Failed to start KasmVNC server. Check full logs at /tmp/kasmvncserver.log" | ||
|
|
||
| set +e | ||
| vncserver -select-de "${DESKTOP_ENVIRONMENT}" -disableBasicAuth > "$VNC_LOG" 2>&1 |
There was a problem hiding this comment.
Is dropping & at the end intentional?
There was a problem hiding this comment.
Yes, vncserver forks all by itself if it successfully launches.
No description provided.