Skip to content

feat: add statefulset image overrides #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 16, 2025
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
- name: Setup Go
uses: actions/setup-go@v2
with:
go-version: 1.22
go-version: 1.23

- name: Install Helm
uses: azure/setup-helm@v4
Expand Down
3 changes: 3 additions & 0 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"makefile.configureOnOpen": false
}
4 changes: 3 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ values which are defined [here](https://github.com/grafana/helm-charts/tree/main
| global.dashboards.timerange | string | `"12h"` | how far back dashboards should look |
| global.externalScheme | string | `"http"` | |
| global.externalZone | string | `"svc.cluster.local"` | |
| global.postgres | object | `{"alerts":{"groups":{"Basic":{"delay":"1m","enabled":true},"Connections":{"delay":"5m","enabled":true,"thresholds":{"critical":0.9,"notify":0.5,"warning":0.8}},"Notifications":{"delay":"15m","enabled":true,"thresholds":{"critical":0.9,"notify":0.5,"warning":0.8}}}},"database":"coder","hostname":"localhost","mountSecret":"secret-postgres","password":null,"port":5432,"sslmode":"disable","username":"coder"}` | postgres connection information NOTE: these settings are global so we can parameterise some values which get rendered by subcharts |
| global.postgres | object | `{"alerts":{"groups":{"Basic":{"delay":"1m","enabled":true},"Connections":{"delay":"5m","enabled":true,"thresholds":{"critical":0.9,"notify":0.5,"warning":0.8}},"Notifications":{"delay":"15m","enabled":true,"thresholds":{"critical":0.9,"notify":0.5,"warning":0.8}}}},"database":"coder","exporter":{"image":"quay.io/prometheuscommunity/postgres-exporter"},"hostname":"localhost","mountSecret":"secret-postgres","password":null,"port":5432,"sslmode":"disable","username":"coder"}` | postgres connection information NOTE: these settings are global so we can parameterise some values which get rendered by subcharts |
| global.postgres.alerts | object | `{"groups":{"Basic":{"delay":"1m","enabled":true},"Connections":{"delay":"5m","enabled":true,"thresholds":{"critical":0.9,"notify":0.5,"warning":0.8}},"Notifications":{"delay":"15m","enabled":true,"thresholds":{"critical":0.9,"notify":0.5,"warning":0.8}}}}` | alerts for postgres |
| global.telemetry | object | `{"metrics":{"scrape_interval":"15s","scrape_timeout":"12s"}}` | control telemetry collection |
| global.telemetry.metrics | object | `{"scrape_interval":"15s","scrape_timeout":"12s"}` | control metric collection |
Expand Down Expand Up @@ -466,4 +466,6 @@ values which are defined [here](https://github.com/grafana/helm-charts/tree/main
| prometheus.serverFiles."prometheus.yml".rule_files[0] | string | `"/etc/config/alerts/*.yaml"` | |
| prometheus.serverFiles."prometheus.yml".scrape_configs | string | `nil` | |
| prometheus.testFramework.enabled | bool | `false` | |
| runbookViewer.image | string | `"dannyben/madness"` | |
| sqlExporter.image | string | `"burningalchemist/sql_exporter"` | |

2 changes: 1 addition & 1 deletion coder-observability/Chart.lock
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@ dependencies:
repository: https://grafana.github.io/helm-charts
version: 0.37.0
digest: sha256:05e0dae0200cabf5cb9e2cfb18a4e166fcaceefaf39827addff4299b18c31d4e
generated: "2024-11-04T08:35:11.202671Z"
generated: "2025-01-16T07:54:38.036598102Z"
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ spec:
spec:
containers:
- name: postgres-exporter
image: quay.io/prometheuscommunity/postgres-exporter
image: {{ .Values.global.postgres.exporter.image }}
args:
- --collector.long_running_transactions
ports:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ spec:
spec:
containers:
- name: madness
image: dannyben/madness
image: {{ .Values.runbookViewer.image }}
ports:
- containerPort: 3000
name: madness
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ spec:
spec:
containers:
- name: sql-exporter
image: burningalchemist/sql_exporter
image: {{ .Values.sqlExporter.image }}
args:
- -config.file=/cfg/config.yaml
ports:
Expand Down
8 changes: 8 additions & 0 deletions coder-observability/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,8 @@ global:
sslmode: disable
# ensure that your secret has a field named `PGPASSWORD`
mountSecret: "secret-postgres"
exporter:
image: "quay.io/prometheuscommunity/postgres-exporter"

# global.postgres.alerts -- alerts for postgres
alerts:
Expand Down Expand Up @@ -146,6 +148,12 @@ global:
# global.dashboards.queryTimeout -- how long until a query in Grafana will timeout after
queryTimeout: 900

runbookViewer:
image: "dannyben/madness"

sqlExporter:
image: "burningalchemist/sql_exporter"

grafana-agent:
enabled: true
fullnameOverride: grafana-agent
Expand Down
Loading