This repository was archived by the owner on May 23, 2021. It is now read-only.
Don't overwrite extracted native module #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
code-asher
force-pushed
the
fix/native-module-segfault
branch
from
725fb91 to
957d5f1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I kept getting segfaults that seemed to correspond with overwriting the native node module, so I added an ID to them and made it so we only write the modules when they don't already exist. This way new versions will write new modules and it won't cause existing instances to segfault if there are any running, and you can run multiple versions at once without anything breaking.
At least, that seems to fix the segfaults, but I think I need to do some more testing to be sure. The Docker container builds and runs without any errors now, in any case.