Skip to content
This repository was archived by the owner on May 23, 2021. It is now read-only.

ARM compilation support #25

Closed
wants to merge 9 commits into from
Closed

ARM compilation support #25

wants to merge 9 commits into from

Conversation

sr229
Copy link
Contributor

@sr229 sr229 commented Oct 14, 2019

Travis recently added ARM compile support so we'll use that instead of hacking our way to ARM support.

This will supersede #23

Kibo Hikari and others added 7 commits July 22, 2019 17:06
3.x was the only available headers in jessie

FIXME: update to buster
Signed-off-by: Kibo Hikari <[email protected]>
Signed-off-by: Kibo Hikari <[email protected]>
Signed-off-by: Ayane Satomi <[email protected]>
Signed-off-by: Ayane Satomi <[email protected]>
@SuperSandro2000
Copy link
Contributor

SuperSandro2000 commented Oct 15, 2019

How do you plan to properly test it on dev machines?
Removing the arm Dockerfiles makes it really hard to properly test arm64 on my amd64 machine without having a arm64 board by hand or an emu ready.
This makes it so easy to be lazy and skip testing which leads to poor quality for arm users.

@sr229
Copy link
Contributor Author

sr229 commented Oct 15, 2019

Removing the arm Dockerfiles makes it really hard to properly test arm64 on my amd64 machine without having a arm64 board by hand or an emu ready.

There's already a way to test ARM images using the QEMU user static Docker images, making my previous strategy obsolete.

The point is to consolidate everything into a single codebase, so every environment gets the same result. The old approach is really dirty and I actually hate that version.

I have a Raspberry Pi 4 and I've been testing code-server personally so I'm just configuring the CIs to build Docker images for it.

This makes it so easy to be lazy and skip testing which leads to poor quality for arm users.

Again we use the same codebase for everything. Where's the lazy in that? You all get the same result as with x86 users.

How do you plan to properly test it on dev machines?

See comment above.

@sr229
Copy link
Contributor Author

sr229 commented Oct 15, 2019

I suggest before commenting @SuperSandro2000, analyze the problem we're trying to solve. In a maintainer standpoint, maintaining multiple Dockerfiles per arch is not okay and it leads to deviation. If we can consolidate this into a single codebase, it's easier to track down issues thereon

@SuperSandro2000
Copy link
Contributor

There's already a way to test ARM images using the QEMU user static Docker images, making my previous strategy obsolete.

I know this. really handy.

You all get the same result as with x86 users.

If you think this is true.

@rogelio-o
Copy link

Any update on this?

@sr229
Copy link
Contributor Author

sr229 commented Jan 7, 2020

Superseded by #35

@sr229 sr229 closed this Jan 7, 2020
@sr229 sr229 deleted the sr229/travis-arm branch January 7, 2020 21:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants