-
Notifications
You must be signed in to change notification settings - Fork 57
Add open_recent option to VS Code desktop #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
01f4743
to
5a64b7f
Compare
5a64b7f
to
ae279c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked through what runTerraformApply
was doing to understand the setup – I think this looks good. Just had a question about what one of the tests was testing for
); | ||
}); | ||
|
||
it("adds open_recent", async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making sure I understand: is the point of this test to make sure that open_recent
gets serialized into the URL as openRecent
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup exactly! Just making sure setting various options results in being added to the URL correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Admittedly the test naming could be better, I went with a adds <option name(s)>
pattern.
@code-asher this will only work when using the VS Code desktop module. Do we need to do something to also support this with the Coder built-in VSCode desktop button? |
I asked the same question here: coder/vscode-coder#241 (comment) I am not sure if we have any way to customize the built-in button so I think we would have to either make this the default or add options for this, but I feel like we should encourage folks to use the module anyway. |
We decided to make |
Together with coder/vscode-coder#272 closes coder/vscode-coder#241
This also (accidentally) fixes what I would imagine is a bug where if there is no folder, it would exclude the URL.