-
Notifications
You must be signed in to change notification settings - Fork 59
feat: Add github-upload-public-key module #241
Conversation
Working on adding some tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest we generalize GitHub URL too by making it an input to the module or better deducing it from the configured GitHub external authentication.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is absolutely sick!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor language things that I think could be helpful!
I realize there is a conflict between making tests pass and the script actually working in workspaces, I think I need to handle the terraform injection (I didn't know this was actually happening at first) as well as env vars for tests. |
Okay input variable issues are fixed, screenshots are updated, I think this is g2g but I'll wait until the eod to merge so yall can take a look at the last couple changes since review. |
Automates uploading Coder public key to Github so users don't have to.
First build:

Subsequent builds:

Github Auth not linked:

Closes https://github.com/coder/customers/issues/542