Skip to content

feat(code-server): add extension_dir variable #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 14, 2024

Conversation

michaelbrewer
Copy link
Contributor

@michaelbrewer michaelbrewer commented Mar 24, 2024

module "code-server" {
  source         = "registry.coder.com/modules/code-server/coder"
  version        = "1.0.10"
  agent_id       = coder_agent.main.id
  folder         = "${local.workspace_home}/${local.folder_name}"
  install_prefix = "${local.workspace_home}/.code-server"
  extensions_dir = "${local.workspace_home}/.code-server/extensions"
  use_cached     = true
  order          = 2
  slug           = "coder-server"
  settings = {
    "workbench.colorTheme" : "Visual Studio Dark"
    "workbench.startupEditor" : "readme"
  }
   extensions = [
     "ms-python.python",
     "hashicorp.terraform",
     "ms-azuretools.vscode-docker"
  ]
}

closes #204

@matifali matifali requested review from mafredri and code-asher March 25, 2024 18:21
@michaelbrewer
Copy link
Contributor Author

Anything else to look at @code-asher @mafredri ?

@code-asher
Copy link
Member

code-asher commented Apr 5, 2024

Nothing from me, I am 👍 with merging.

If the exit code works in Microsoft's server, maybe it was recently fixed. I think we have a pending update, I will see if it resolves the issue today. It did not

@code-asher
Copy link
Member

code-asher commented Apr 6, 2024

Figured out the exit code issue, next release today will fix this (will be promoted to a full release early next week).

Edit: out now, 4.23.0

@matifali matifali merged commit c4df384 into coder:main Apr 14, 2024
2 checks passed
@michaelbrewer michaelbrewer deleted the feat/code-extension-dir branch April 14, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants