Skip to content

chore: pass usage app name to coder ssh #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 25, 2024
Merged

chore: pass usage app name to coder ssh #442

merged 6 commits into from
Jun 25, 2024

Conversation

f0ssel
Copy link
Collaborator

@f0ssel f0ssel commented Jun 22, 2024

Relies on coder/coder#13637.

This signals to the CLI to track workspace usage with the jetbrains usage app name.

@f0ssel f0ssel requested a review from code-asher June 22, 2024 23:14
@f0ssel
Copy link
Collaborator Author

f0ssel commented Jun 22, 2024

Both locally and in CI I'm seeing this fail to build with the following error:

> Could not find com.jetbrains.gateway:JetBrainsGateway:233.14808-EAP-CANDIDATE-SNAPSHOT.
https://github.com/coder/jetbrains-coder/actions/runs/9628941608/job/26557738545?pr=442#step:5:329

Update:
Updating the version to 233.15325-EAP-CANDIDATE-SNAPSHOT seemed to fix it.

Copy link
Contributor

github-actions bot commented Jun 24, 2024

Qodana Community for JVM

2 new problems were found

Inspection name Severity Problems
Incorrect string capitalization 🔶 Warning 1
Redundant nullable return type 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true
Contact Qodana team

Contact us at [email protected]

Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me! Though I mentioned this on the other PR but I think we will have to use the flag after all for Windows. We could check against the CLI version before adding the flag. There is some precedence for it here:

/**
* The supported features of the CLI.
*/
data class Features(
val disableAutostart: Boolean = false,
)

// Autostart with SSH was added in 2.5.0.
disableAutostart = version >= SemVer(2, 5, 0),

@f0ssel f0ssel requested a review from code-asher June 25, 2024 15:25
@f0ssel
Copy link
Collaborator Author

f0ssel commented Jun 25, 2024

@code-asher I've updated it to check the version and use the flag, thanks for the catch on the windows compatibility.

Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!!

@f0ssel f0ssel merged commit 950c3b1 into main Jun 25, 2024
6 checks passed
@f0ssel f0ssel deleted the f0ssel/usage-app branch June 25, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants