-
Notifications
You must be signed in to change notification settings - Fork 15
chore: pass usage app name to coder ssh #442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Both locally and in CI I'm seeing this fail to build with the following error:
Update: |
Qodana Community for JVM2 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/[email protected]
with:
upload-result: true Contact Qodana teamContact us at [email protected]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me! Though I mentioned this on the other PR but I think we will have to use the flag after all for Windows. We could check against the CLI version before adding the flag. There is some precedence for it here:
jetbrains-coder/src/main/kotlin/com/coder/gateway/cli/CoderCLIManager.kt
Lines 109 to 114 in dceb578
/** | |
* The supported features of the CLI. | |
*/ | |
data class Features( | |
val disableAutostart: Boolean = false, | |
) |
jetbrains-coder/src/main/kotlin/com/coder/gateway/cli/CoderCLIManager.kt
Lines 447 to 448 in dceb578
// Autostart with SSH was added in 2.5.0. | |
disableAutostart = version >= SemVer(2, 5, 0), |
@code-asher I've updated it to check the version and use the flag, thanks for the catch on the windows compatibility. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!!
Relies on coder/coder#13637.
This signals to the CLI to track workspace usage with the
jetbrains
usage app name.