Skip to content

Make version column display outdated status #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Make version column display outdated status #438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@

## Unreleased

### Fixed

- The version column now displays "Up to date" or "Outdated" instead of
duplicating the status column.

## 2.11.7 - 2024-05-22

### Fixed
Expand Down
8 changes: 7 additions & 1 deletion src/main/kotlin/com/coder/gateway/views/steps/CoderWorkspacesStepView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -892,8 +892,14 @@
}

private class WorkspaceVersionColumnInfo(columnName: String) : ColumnInfo<WorkspaceAgentListModel, String>(columnName) {
override fun valueOf(workspace: WorkspaceAgentListModel?): String? {

Check warning on line 895 in src/main/kotlin/com/coder/gateway/views/steps/CoderWorkspacesStepView.kt

View workflow job for this annotation

GitHub Actions / Qodana Community for JVM

Redundant nullable return type 

'valueOf' always returns non-null type
return workspace?.status?.label
return if (workspace == null) {
"Unknown"
} else if (workspace.workspace.outdated) {
"Outdated"
} else {
"Up to date"
}
}

override fun getRenderer(item: WorkspaceAgentListModel?): TableCellRenderer {
Expand Down
Loading