Bypass download if CLI version matches #245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a bit faster than waiting for a 304 but more importantly it works if the user customizes the download source to be a place that does not have the same etag support that Coder does. The test bypasses Windows since we would need to create an executable there for the test. We could split out the exec and the parsing although I am not sure it is worth the noise. The part most likely to break between platforms is probably the exec, not the parsing?
johnstcn
approved these changes
May 10, 2023
src/main/kotlin/com/coder/gateway/views/steps/CoderWorkspacesStepView.kt
Outdated
Show resolved
Hide resolved
code-asher
force-pushed
the
version-check
branch
3 times, most recently
from
9dd62c9 to
a2956e9
Compare
johnstcn
approved these changes
May 11, 2023
Comment on lines
+470
to
+474
| null | ProcessInitException | ||
| """echo '{"foo": true, "baz": 1}'""" | InvalidVersionException | ||
| """echo '{"version: '""" | JsonSyntaxException | ||
| "exit 0" | InvalidVersionException | ||
| "exit 1" | InvalidExitValueException |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit faster than waiting for a 304 but more importantly it works if the user customizes the download source to be a place that does not have the same etag support that Coder does.
The test bypasses Windows since we would need to create an executable there for the test. We could split out the exec and the parsing although I am not sure it is worth the noise. The part most likely to break between platforms is probably the exec, not the parsing?
We do indirectly test the version parsing on Windows with the test that goes against dev.coder.com.