feat: Make cache TTL configurable #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylecarbs
reviewed
Jul 25, 2023
| @@ -111,6 +111,10 @@ type Options struct { | |||
| // It will override CacheRepo if both are specified. | |||
| LayerCacheDir string `env:"LAYER_CACHE_DIR"` | |||
|
|
|||
| // CacheTTLDays is the number of days to use cached layers before | |||
| // expiring them. Defaults to 7 days. | |||
| CacheTTLDays int `env:"CACHE_TTL_DAYS"` | |||
There was a problem hiding this comment.
Should we make this a time.Duration instead? Go can parse pretty nice strings like "7d" or "12hr".
There was a problem hiding this comment.
I was thinking about that, but since days aren't supported in the format, it's an awkward way to specify long time periods. Okay with me if you prefer that.
There was a problem hiding this comment.
Ahh, you're right I forgot. I think days is fine in that case. It's weird that someone would want to cache for hours anyways.
kylecarbs
approved these changes
Jul 25, 2023
|
@aaronlehmann could you resolve the new conflicts on your branch? Then feel free to auto-merge! |
Add a CACHE_TTL_DAYS env var to control layer cache TTL. Also, fix int handling in OptionsFromEnv (which is also needed for GIT_CLONE_DEPTH).
aaronlehmann
force-pushed
the
configurable-cache-ttl
branch
from
55cb07e to
59d38c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
CACHE_TTL_DAYSenv var to control layer cache TTL.Also, fix int handling in
OptionsFromEnv(which is also needed forGIT_CLONE_DEPTH).