fix: improve cached image startup and cache features #353
+704
−598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
commented
Sep 23, 2024
johnstcn
reviewed
Sep 23, 2024
mtojek
approved these changes
Sep 24, 2024
mafredri
changed the title
johnstcn
pushed a commit
that referenced
this pull request
Sep 26, 2024
(cherry picked from commit 08bd99b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature files are cached in
/.envbuilder/features, including their devcontainer JSON configuration. These JSON files can later be used to compute a fully fledged devcontainer file that combines project and features.We also fix startup from an envbuilder built image so that we don't accidentally re-build the image.
Fixes #334
(I recommend reviewing with ignore whitespace on: https://github.com/coder/envbuilder/pull/353/files?w=1)