fix(devcontainer): parse user in multi-stage builds #343
+281
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
force-pushed
the
mafredri/fix-devcontainer-multistage-parsing
branch
from
c1ca00e to
cd3cb2e
Compare
johnstcn
approved these changes
Sep 11, 2024
Comment on lines
+373
to
384
| // If we can't find a user command, try to find the user from | ||
| // the image. | ||
| ref, err := name.ParseReference(strings.TrimSpace(stage.BaseName)) | ||
| if err != nil { | ||
| return "", fmt.Errorf("parse image ref %q: %w", stage.BaseName, err) | ||
| } | ||
| user, err := UserFromImage(ref) | ||
| if err != nil { | ||
| return "", fmt.Errorf("user from image %s: %w", ref.Name(), err) | ||
| } | ||
| return user, nil | ||
| } |
There was a problem hiding this comment.
It's unfortunate to have to reach out to the remote repo to get the image manifest, but it looks like this is our only option since there's no local Docker daemon to ask :(
There was a problem hiding this comment.
I agree 😔, hopefully it's rarely needed.
Comment on lines
+360
to
+362
| if stage.BaseName == "scratch" { | ||
| return "", nil | ||
| } |
There was a problem hiding this comment.
Confirmed that building FROM scratch results in a manifest with User: "".
Co-authored-by: Cian Johnston <[email protected]>
johnstcn
pushed a commit
that referenced
this pull request
Sep 26, 2024
Co-authored-by: Cian Johnston <[email protected]> (cherry picked from commit df8ea67)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #231
There's some more assumption and parsing fixing I want to do in
devcontainerpackage, but I'll make other PRs for those.