fix: prevent git progress writer race reading stageNumber #309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the progress writer runs in a goroutine, it can call the write function after the git operation has exited and while the next stage is starting, resulting in a race. This fixes the race by using a second variable and closing the writer early. An alternative fix is to rewrite the progress writer to be synchronous.
johnstcn
approved these changes
Aug 12, 2024
johnstcn
pushed a commit
that referenced
this pull request
Aug 15, 2024
(cherry picked from commit 7c486bb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the progress writer runs in a goroutine, it can call the write
function after the git operation has exited and while the next stage is
starting, resulting in a race. This fixes the race by using a second
variable and closing the writer early.
An alternative fix is to rewrite the progress writer to be synchronous.