ci: fix version script and update release.yaml #303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
commented
Aug 7, 2024
| @@ -54,25 +54,17 @@ if [[ "${ENVBUILDER_RELEASE:-}" == *t* ]]; then | |||
| # $last_tag will equal `git describe --always` if we currently have the tag | |||
| # checked out. | |||
| if [[ "${last_tag}" != "$(git describe --always)" ]]; then | |||
| # make won't exit on $(shell cmd) failures, so we have to kill it :( | |||
There was a problem hiding this comment.
review: I don't think we need this given how we're building
johnstcn
commented
Aug 7, 2024
| @@ -39,3 +39,9 @@ cdroot() { | |||
| log() { | |||
| echo "$*" 1>&2 | |||
| } | |||
|
|
|||
| # error prints an error message and returns an error exit code. | |||
There was a problem hiding this comment.
review: missed copy-pasta
johnstcn
commented
Aug 7, 2024
| - name: Get version | ||
| id: get-version | ||
| env: | ||
| ENVBUILDER_RELEASE: "t" |
There was a problem hiding this comment.
review: the updated script will emit -dev versions unless this is explicitly set. In this case it will validate that the version is an annotated tag.
mafredri
approved these changes
Aug 7, 2024
dannykopping
approved these changes
Aug 7, 2024
johnstcn
added a commit
that referenced
this pull request
Aug 8, 2024
johnstcn
added a commit
that referenced
this pull request
Aug 8, 2024
johnstcn
added a commit
that referenced
this pull request
Aug 8, 2024
johnstcn
added a commit
that referenced
this pull request
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some issues in the version script related to dev versions.