fix: Use fallback image if devcontainer.json doesn't specify an image or Dockerfile #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… or Dockerfile We might want a simple devcontainer.json that does something like reference a feature or set environment variables, but leaves the image as the default (fallback) image.
|
cc @kylecarbs |
kylecarbs
approved these changes
Jul 13, 2023
There was a problem hiding this comment.
@aaronlehmann it'd be awesome to have an integration test for this.
I'm happy to add one too - the only dependency is Docker!
Co-authored-by: Kyle Carberry <[email protected]>
That would be great! |
|
@aaronlehmann added! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We might want a simple devcontainer.json that does something like reference a feature or set environment variables, but leaves the image as the default (fallback) image.