feat: support starting from an already-built image #296
+140
−62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 2, 2024
mafredri
reviewed
Aug 3, 2024
| @@ -1138,8 +1149,8 @@ ENTRYPOINT [%q]`, exePath, exePath, exePath) | |||
| }, | |||
| SrcContext: buildParams.BuildContext, | |||
|
|
|||
| // For cached image utilization, produce reproducible builds. | |||
| Reproducible: opts.PushImage, | |||
| // When performing a cache probe, always perform reproducible snapshots. | |||
johnstcn
commented
Aug 3, 2024
Comment on lines
+1107
to
+1111
| for _, path := range []string{magicImageDest, envbuilderBinDest, magicTempDir} { | ||
| if err := opts.Filesystem.Remove(path); err != nil { | ||
| opts.Logger(log.LevelWarn, "failed to clean up magic temp dir from build context: %w", err) | ||
| } | ||
| } |
There was a problem hiding this comment.
note: there is no fs.RemoveAll :(
mafredri
approved these changes
Aug 3, 2024
johnstcn
added a commit
that referenced
this pull request
Aug 5, 2024
- Extracts 'magic directives' to constants.go. - Adds 'magic image' file to signify envbuilder should skip the destructive 'build image' stage. - Modifies logic for copying binary into built image: we now copy to build context and remove it after build finishes to avoid leaving around files owned by root:root. Also ensures files are created with consistent permissions. (cherry picked from commit 6afe89e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #291
Depends on coder/kaniko#19
Builds on top of #292
root:root. Also ensures files are created with consistent permissions.