Skip to content

feat: prefix cached image with ENVBUILDER_CACHED_IMAGE in log output #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

johnstcn
Copy link
Member

When running ENVBUILDER_GET_CACHED_IMAGE, prefixes the cached image with the string ENVBUILDER_CACHED_IMAGE=.

This can then be consumed more easily e.g.

resource "docker_container" "check_cache" {                                                                                                                                                                   
  image = var.envbuilder_image
  name = "envbuilder-get-cached-image"
  attach = true
  logs = true
  must_run = false
  network_mode = "host"
  env = [ 
    "ENVBUILDER_GIT_URL=${var.git_repo}",
    "ENVBUILDER_DEVCONTAINER_DIR=${var.devcontainer_dir}",
    "ENVBUILDER_GET_CACHED_IMAGE=1",
    "ENVBUILDER_CACHE_REPO=localhost:5000/envbuilder-cache",
  ]
}

locals {
  logs = docker_container.check_cache.container_logs
  regex_match = try(regex("ENVBUILDER_CACHED_IMAGE=([^\\S]+)", local.logs), [""])
  cached_image_ref = local.regex_match[0]
}
 
resource "docker_container" "cached" {
  image = coalesce(local.cached_image_ref, var.envbuilder_image)
  name = "envbuilder-workspace"
  network_mode = "host"
  env = [ 
    "ENVBUILDER_GIT_URL=${var.git_repo}",
    "ENVBUILDER_DEVCONTAINER_DIR=${var.devcontainer_dir}",
    "ENVBUILDER_INIT_SCRIPT=sleep infinity",
    "ENVBUILDER_PUSH_IMAGE=1",
    "ENVBUILDER_CACHE_REPO=localhost:5000/envbuilder-cache",
  ]
}

@johnstcn johnstcn self-assigned this Jun 28, 2024
@johnstcn johnstcn requested review from dannykopping and mtojek June 28, 2024 10:26
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@johnstcn johnstcn merged commit ed52e3c into main Jun 28, 2024
4 checks passed
@johnstcn johnstcn deleted the cj/ENVBUILDER_CACHED_IMAGE branch June 28, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants