Skip to content

fix(devcontainer): correctly parse feature with digest #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

maxbrunet
Copy link
Contributor

Hello! 👋

Parsing an image with a digest like ghcr.io/coder/envbuilder:0.2.9@sha256:b51153d8cc1235986707d5f61949884444f2b4c4f64b15b5506cb5484bfa8a93 using NewTag does not work:

repository can only contain the characters `abcdefghijklmnopqrstuvwxyz0123456789_-./`: coder/envbuilder:0.2.9@sha256

ParseReference supports both tag and digest, and produces the same result.

@maxbrunet maxbrunet force-pushed the fix/devcontainer/feature-digest branch from 651d803 to d987f0b Compare June 25, 2024 01:20
@matifali matifali requested a review from johnstcn June 25, 2024 05:12
@johnstcn johnstcn self-assigned this Jun 25, 2024
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! name.ParseReference uses NewTag under the hood (falling back to NewDigest), so this looks fine to me. 👍

@johnstcn johnstcn merged commit 48c8fa3 into coder:main Jun 25, 2024
4 checks passed
@maxbrunet maxbrunet deleted the fix/devcontainer/feature-digest branch June 25, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants